Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type assertions in add_expression and attach_expression functions #1055

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Feb 26, 2025

Add type assertions in add_expression and attach_expression functions

This should help make it a bit faster by making all three functions more type stable. All three functions are similarly typed now.

@abelsiqueira abelsiqueira changed the title expression improvements Add type assertions in add_expression and attach_expression functions Feb 26, 2025
@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Benchmark Results

e8e59d5... 5d865ad... e8e59d5... / 5d865ad...
energy_problem/create_model 35.3 ± 2 s 33 ± 1.9 s 1.07
energy_problem/input_and_constructor 27.4 ± 0.18 s 27.7 ± 0.11 s 0.989
time_to_load 2.61 ± 0.023 s 2.63 ± 0.016 s 0.992
e8e59d5... 5d865ad... e8e59d5... / 5d865ad...
energy_problem/create_model 0.243 G allocs: 12.1 GB 0.204 G allocs: 11.4 GB 1.06
energy_problem/input_and_constructor 26.8 M allocs: 0.952 GB 26.8 M allocs: 0.952 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@abelsiqueira abelsiqueira force-pushed the expression-improvements branch from 5b5b771 to 7346ba9 Compare February 26, 2025 10:41
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (e8e59d5) to head (5d865ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          29       29           
  Lines         985      985           
=======================================
  Hits          964      964           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira mentioned this pull request Feb 26, 2025
4 tasks
@abelsiqueira abelsiqueira force-pushed the expression-improvements branch from 7346ba9 to 5d865ad Compare February 26, 2025 12:24
@abelsiqueira abelsiqueira marked this pull request as ready for review February 26, 2025 12:39
Copy link
Member

@clizbe clizbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@datejada datejada merged commit 559ed85 into main Mar 3, 2025
7 checks passed
@abelsiqueira abelsiqueira deleted the expression-improvements branch March 4, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants