Remove graph dependency from src/constraints/consumer.jl #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsiqueira
force-pushed
the
943-consumer-constraints
branch
from
97fc644 to
6206bbf
Compare
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 95.91% 95.92% +0.01%
==========================================
Files 29 29
Lines 1027 1030 +3
==========================================
+ Hits 985 988 +3
Misses 42 42 ☔ View full report in Codecov by Sentry. |
abelsiqueira
force-pushed
the
943-consumer-constraints
branch
from
6206bbf to
0dc168c
Compare
|
@datejada, I've updated this to follow the new strategy. The code is still slow, though, so we might want to wait until all rep_periods_profiles are removed to see if it's possible to make it better. |
abelsiqueira
force-pushed
the
943-consumer-constraints
branch
from
0dc168c to
f6e89c8
Compare
abelsiqueira
force-pushed
the
943-consumer-constraints
branch
from
f6e89c8 to
e9ff4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #942
Closes #943