From b8ec3f88267f341245263dd7570e97d6abef8aab Mon Sep 17 00:00:00 2001
From: Muffin <muffin@muffin.ink>
Date: Tue, 28 Jan 2025 22:38:27 -0600
Subject: [PATCH] Rename --mac-legacy to --mac-legacy-10.13-10.14 to prepare
 for future

Electron 33 drops support for macOS 10.15 so we may
end up having two different macOS legacy versions.

While the macOS 10.13/10.14 version would run fine on
macOS 10.15 as well, that would be a significant downgrade
of Chromium which tends to result in data loss.

This is starting to get a bit out of hand.
---
 .github/workflows/build.yml   | 2 +-
 .github/workflows/release.yml | 2 +-
 docs/index.html               | 1 +
 release-automation/README.md  | 4 ++--
 release-automation/build.js   | 6 +++---
 5 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index a1e8b13f..0eb83a66 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -37,7 +37,7 @@ jobs:
       if: runner.os == 'macOS'
       run: |
         node release-automation/build.js --mac --universal
-        node release-automation/build.js --mac-legacy --x64
+        node release-automation/build.js --mac-legacy-10.13-10.14 --x64
     - name: Package Linux
       if: runner.os == 'Linux'
       run: |
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index d7972c2d..ba30d4cc 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -57,7 +57,7 @@ jobs:
         # @electron/notaraize documentation says key should be an absolute path
         export APPLE_API_KEY="$(pwd)/$APPLE_API_KEY_NAME"
         node release-automation/build.js --mac --universal --production
-        node release-automation/build.js --mac-legacy --x64 --production
+        node release-automation/build.js --mac-legacy-10.13-10.14 --x64 --production
         # for safety
         rm "$APPLE_API_KEY_NAME"
       env:
diff --git a/docs/index.html b/docs/index.html
index 94da196a..c1560270 100644
--- a/docs/index.html
+++ b/docs/index.html
@@ -546,6 +546,7 @@ <h1 class="header">
 
     <script>
       // FIXME: when >= 1.13.2 is released, update the .deb packages to not hardcode 1.13.1
+      // FIXME: when >= 1.13.2 is released, macOS legacy download name may need to be updated
       const VERSION = '1.13.0';
 
       // OS-specific styles
diff --git a/release-automation/README.md b/release-automation/README.md
index 4842e847..ce11421e 100644
--- a/release-automation/README.md
+++ b/release-automation/README.md
@@ -28,8 +28,8 @@ You must specify which platform to build for:
 --mac
     Create app for macOS 10.15 and later.
 
---mac-legacy
-    Create app for macOS 10.13 and later (less secure than --mac).
+--mac-legacy-10.13-10.14
+    Create app for macOS 10.13 and 10.14 (less secure than --mac).
 
 --mac-dir
     Generate executables for macOS 10.15 and later but don't package into a complete DMG installer.
diff --git a/release-automation/build.js b/release-automation/build.js
index 06bc83e8..a9e3cf55 100644
--- a/release-automation/build.js
+++ b/release-automation/build.js
@@ -251,7 +251,7 @@ const buildMac = () => build({
   }
 });
 
-const buildMacLegacy = () => {
+const buildMacLegacy10131014 = () => {
   // This is the last release of Electron 26
   // Electron 27 dropped support for macOS 10.13 and 10.14
   const LEGACY_ELECTRON_VERSION = '26.6.10';
@@ -263,7 +263,7 @@ const buildMacLegacy = () => {
     legacy: true,
     extraConfig: {
       mac: {
-        artifactName: '${productName} Legacy Setup ${version}.${ext}'
+        artifactName: '${productName} Legacy 10.13 10.14 Setup ${version}.${ext}'
       }
     },
     prepare: async (archName) => {
@@ -318,7 +318,7 @@ const run = async () => {
     '--windows-dir': buildWindowsDir,
     '--microsoft-store': buildMicrosoftStore,
     '--mac': buildMac,
-    '--mac-legacy': buildMacLegacy,
+    '--mac-legacy-10.13-10.14': buildMacLegacy10131014,
     '--mac-dir': buildMacDir,
     '--debian': buildDebian,
     '--tarball': buildTarball,