Kill jsts #9
Closed
Kill jsts #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there a reason this was never merged? |
|
@jljorgenson18 it was never entirely complete - the greiner-hormann module has been in a state of limbo for awhile. In the next few weeks we're doing some sprinting around polygon clipping algorithms, which means we'll hopefully have some news in terms of fixing turf intersect / difference / union soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the greiner-hormann algorithm that I've been working on implementing. It's considerably faster than JSTS, and removes our dependency on JSTS, aside from turf-buffer.
There are likely some quirks / edge case failures here, but we'll deal with those as they come up. Here's some known differences in the behavior: