Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for Adapt to 4 #261

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Bump compat for Adapt to 4 #261

merged 1 commit into from
Feb 12, 2024

Conversation

fhagemann
Copy link
Contributor

@fhagemann fhagemann commented Jan 31, 2024

Adapt v4.0.0 features breaking changes in Adapt.ndims, Adapt.eltype and Adapt.parent
(see https://github.com/JuliaGPU/Adapt.jl/releases/tag/v4.0.0)

DistributionsAD.jl seems to be using only Adapt.adapt here, so it should not be affected by the changes in Adapt v4.0.0.

Closes #262.

@avik-pal
Copy link
Collaborator

@devmotion can this be merged and tagged? It is holding back a downgrade CI

@devmotion
Copy link
Member

I'll merge if tests pass.

It is holding back a downgrade CI

How is that possible? Doesn't a test failure of downgrade CI just indicate that the compat bounds of your package have to be fixed?

@avik-pal
Copy link
Collaborator

avik-pal commented Feb 12, 2024

Had to drop compat with Adapt 3 at one place, and this is the only one currently in the dependency chain with no Adapt 4 compat. Should have been more clear -- it is a resolution failure not a test failure

@devmotion
Copy link
Member

I still don't understand, how can you drop Adapt 3 if it is not supported yet by DistributionsAD? Shouldn't then the regular package tests, installation etc. fail as well?

@avik-pal
Copy link
Collaborator

The compat has not yet been dropped. I was running downgrade CI and after running through a few combinations this is only one which doesn't have Adapt 4, and then testing locally with this branch the dependency resolution works out

@devmotion devmotion merged commit a19c345 into TuringLang:master Feb 12, 2024
15 checks passed
@devmotion devmotion mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants