Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Curse Spell does not work as intended for clients in multiplayer #48

Closed
addictgamer opened this issue Jan 17, 2017 · 1 comment
Closed

Remove Curse Spell does not work as intended for clients in multiplayer #48

addictgamer opened this issue Jan 17, 2017 · 1 comment
Labels
bug
Milestone
Barony Next

Comments

@addictgamer
Copy link
Collaborator

addictgamer commented Jan 17, 2017 •
edited
Loading

When playing as a client in multiplayer, the remove curse spell does not function as intended.
It should pop open the Remove Curse GUI. Instead, when a client receives the RCUR packet, it runs the code for the remove curse scroll (which, indeed, also triggers the RCUR packet).

Prescribed remedy:
Create a new packet for this situation.
When that packet is received, pop open the Remove Curse GUI.
@crkellen crkellen mentioned this issue Aug 15, 2017
Closed
@crkellen crkellen mentioned this issue Sep 20, 2017
Open
8 tasks
@crkellen crkellen mentioned this issue Jan 21, 2018
Merged
addictgamer pushed a commit that referenced this issue Feb 18, 2018
@WALLOFJUSTICE
Merge pull request #48 from WALLOFJUSTICE/dev-3.0.0
eadce6c 
Dev 3.0.0
addictgamer added a commit that referenced this issue Feb 18, 2018
@addictgamer
Merge pull request #320 from crkellen/issue-48-ClientRemoveCurseSpellGUI
729b04a 
Fix Issue #48 - Client Remove Curse Spell does not open GUI
@addictgamer
Copy link
Collaborator Author

Fixed in #320

@addictgamer addictgamer added this to the Barony Next milestone Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Barony Next
Development

No branches or pull requests
1 participant
@addictgamer