Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right clicking on the calendar triggers changes. #183

Open
miuy56dc opened this issue May 9, 2016 · 3 comments
Open

Right clicking on the calendar triggers changes. #183

miuy56dc opened this issue May 9, 2016 · 3 comments

Comments

@miuy56dc
Copy link

miuy56dc commented May 9, 2016

If use the event mousedown when use right mouse button, it is will display a menu and if use the event it won't have a side affect.

@Twipped
Copy link
Owner

Twipped commented May 9, 2016

I had a reason for going with mouse down instead of click, but it's been a few years. Probably just response time, I wanted it to react immediately to input. I think I was planning to support dragging across dates, and just never got around to implementing it. I'd rather detect the right click and not update in that case.

I'll see about addressing it next time I'm in the codebase.

@Twipped Twipped changed the title Use click instead mousedown Right clicking on the calendar triggers changes. May 9, 2016
@miuy56dc
Copy link
Author

There is another question about use mousedown. Whichever left or right mouse down, it will trigger a view-changed event, and I subscribe the view-changed event to do something. But if I choose the wrong date, it is also trigger the view-changed event. If use click I can move the mouse and it won't trigger the event.

@Twipped
Copy link
Owner

Twipped commented May 10, 2016

Hmm, yes, it probably shouldn't trigger the event until mouse up. I'll look into that at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants