Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontvalidator does not properly parse mkv #17

Open
McBaws opened this issue Nov 23, 2021 · 1 comment
Open

Fontvalidator does not properly parse mkv #17

McBaws opened this issue Nov 23, 2021 · 1 comment

Comments

@McBaws
Copy link

McBaws commented Nov 23, 2021

When using fontvalidator directly on mkv files, it will not properly detect either the font files or the sub track. Instead, it will only say 'Ignoring non-font attachment FONT.ttf' for each font, and nothing else. The fact it does not give missing font errors when run also implies that it is not detecting the subtitle tracks correctly either.

The solution I found for both of these was removing the "b" from "b'S_TEXT/ASS':" on line 333 and removing all of the "b"s from before the strings in the FONT_MIMETYPE set on lines 388-396. The script worked perfectly for me after removing these. I'm guessing these stopped the script from properly detecting the font filetype or the tracks which were subtitles.

@Animorphs
Copy link

Same issue here, pull request #15 also fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants