Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce self-contained builds of the app #292

Merged
merged 6 commits into from
May 15, 2024
Merged

Produce self-contained builds of the app #292

merged 6 commits into from
May 15, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Apr 29, 2024

Produce self-contained builds of LightBulb that don't require manual installation of .NET, with the downside of a much larger download size.

With the usage of Avalonia, this has become viable as it has a lot smaller file size overhead compared to WPF.

File size difference:

  • 34.3mb vs 9.5mb (before) for Installer
  • 43mb vs 11.5mb (before) for Portable (and auto-update)

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (03218e8) to head (4b45e3e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files           7        7           
  Lines         192      192           
  Branches       15       15           
=======================================
  Hits          185      185           
  Misses          6        6           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz merged commit 989ec1a into master May 15, 2024
8 checks passed
@Tyrrrz Tyrrrz deleted the self-contained branch May 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant