Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WDT (Completely un-tested) #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add WDT (Completely un-tested) #28

wants to merge 2 commits into from

Conversation

reeganm
Copy link
Member

@reeganm reeganm commented Feb 12, 2020

No description provided.

@reeganm reeganm self-assigned this Feb 12, 2020
@reeganm reeganm linked an issue Feb 12, 2020 that may be closed by this pull request
We should really add a watchdog timer to protect us against threads freezing #27
Open
ewhitby
ewhitby approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@ewhitby ewhitby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just to confirm, for a watchdog timer if it resets the system we would go back to FC_STANDBY state with valves closed and relays open, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewhitby ewhitby ewhitby approved these changes

@zac-kwong zac-kwong Awaiting requested review from zac-kwong

@kaileycole kaileycole Awaiting requested review from kaileycole

Assignees

@reeganm reeganm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should really add a watchdog timer to protect us against threads freezing
2 participants
@reeganm @ewhitby