Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[presentation & DFG-Viewer] Use latest code with TYPO3 release 10 #29

Closed
stweil opened this issue Sep 14, 2022 · 5 comments
Closed

[presentation & DFG-Viewer] Use latest code with TYPO3 release 10 #29

stweil opened this issue Sep 14, 2022 · 5 comments
Assignees
Labels
dfg-viewer Issue concerns DFG Viewer presentation Issue concerns Kitodo.Presentation TODO

Comments

@stweil
Copy link
Member

stweil commented Sep 14, 2022

The dfg-viewer-5.3-ocr branch is currently based on older code which requires the old TYPO3 release 9.

How much work is needed to update that to newer code? Is there anything still missing to get support for newer TYPO3 releases?

@csidirop
Copy link
Member

csidirop commented Sep 14, 2022

This is a good question, but one that should be asked here https://github.com/slub/dfg-viewer/issues

Edit: For the record: slub/dfg-viewer#208 and slub/dfg-viewer#205

@stweil
Copy link
Member Author

stweil commented Sep 15, 2022

That pull request was merged, the issue is closed. The dfg-viewer master branch should support TYPO3 10.4 (see here).

@csidirop
Copy link
Member

Yes but its still not a final version and can therefore undergo yet greater structural changes. Sure we could test it.

@csidirop csidirop self-assigned this Sep 19, 2022
@csidirop csidirop changed the title Use latest code with TYPO3 release 10 [presentation & DFG-Viewer] Use latest code with TYPO3 release 10 Sep 19, 2022
@csidirop csidirop moved this from 🆕 New to 📋 Backlog in OCR-D Kitodo.Presentation Sep 19, 2022
@csidirop csidirop moved this from 📋 Backlog to 🆕 New in OCR-D Kitodo.Presentation Sep 19, 2022
@csidirop
Copy link
Member

Docker Image with the newest DFG-Viewer Code: dfg-viewer-dev
OCR-On-Demand need more time.

@csidirop csidirop moved this from 🆕 New to 🔖 Ready in OCR-D Kitodo.Presentation Oct 10, 2022
@csidirop csidirop moved this from 🔖 Ready to 🏗 In progress in OCR-D Kitodo.Presentation Feb 10, 2023
@csidirop
Copy link
Member

csidirop commented Feb 10, 2023

Devbranch: https://github.com/csidirop/kitodo-presentation-docker/tree/update

At this point there is only one issue left with the button (de-)activating the full text. It is deactivated when no full texts are remote available. So old or newly generated full text wont get shown. done in csidirop/kitodo-presentation@815f1f6

Todo:

Presentation code can be found in: https://github.com/csidirop/kitodo-presentation/tree/4.x-ocr
DFG-Viewer code can be found in: https://github.com/csidirop/dfg-viewer/tree/6.x-ocr

@csidirop csidirop moved this from 🏗 In progress to 👀 In review in OCR-D Kitodo.Presentation Feb 15, 2023
@csidirop csidirop pinned this issue Feb 16, 2023
@csidirop csidirop moved this from 👀 In review to ✅ Done in OCR-D Kitodo.Presentation Jun 23, 2023
@csidirop csidirop closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dfg-viewer Issue concerns DFG Viewer presentation Issue concerns Kitodo.Presentation TODO
Projects
Status: Done
Development

No branches or pull requests

2 participants