Skip to content

Commit

Permalink
set language default to eng
Browse files Browse the repository at this point in the history
  • Loading branch information
aborel committed Nov 18, 2024
1 parent 8395077 commit 1a34d94
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 8 deletions.
14 changes: 10 additions & 4 deletions src/chrome/content/zoteroocr.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,16 @@ Zotero.OCR = new function() {
parameters.push(ocrbase);
parameters.push('--psm');
parameters.push(Zotero.Prefs.get("zoteroocr.PSMMode"));
if (Zotero.Prefs.get("zoteroocr.language")) {
parameters.push('-l');
parameters.push(Zotero.Prefs.get("zoteroocr.language"));
}

let ocrLanguage = Zotero.Prefs.get("zoteroocr.language");
// Convert existing instances with older or buggy defaults to eng
if (!ocrLanguage || ocrLanguage === 'undefined') {
ocrLanguage = 'eng';
Zotero.Prefs.set("zoteroocr.language", ocrLanguage);
}
parameters.push('-l');
parameters.push(ocrLanguage);

parameters.push('txt');
if (Zotero.Prefs.get("zoteroocr.outputPDF")) {
parameters.push('pdf');
Expand Down
3 changes: 2 additions & 1 deletion src/defaults/preferences/defaults.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// don't set ocrPath, language by default
// don't set ocrPath by default
pref("extensions.zotero.zoteroocr.language", "eng")
pref("extensions.zotero.zoteroocr.outputNote", true);
pref("extensions.zotero.zoteroocr.outputPDF", true);
pref("extensions.zotero.zoteroocr.overwritePDF", false);
Expand Down
2 changes: 2 additions & 0 deletions src/prefs.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
pref("extensions.zotero.zoteroocr.language", "eng")
pref("extensions.zotero.zoteroocr.outputNote", true);
pref("extensions.zotero.zoteroocr.outputNote", true);
pref("extensions.zotero.zoteroocr.outputPDF", true);
pref("extensions.zotero.zoteroocr.overwritePDF", false);
Expand Down
12 changes: 9 additions & 3 deletions src/zotero-ocr.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,16 @@ ZoteroOCR = {
parameters.push(ocrbase);
parameters.push('--psm');
parameters.push(Zotero.Prefs.get("zoteroocr.PSMMode"));
if (Zotero.Prefs.get("zoteroocr.language")) {
parameters.push('-l');
parameters.push(Zotero.Prefs.get("zoteroocr.language"));

let ocrLanguage = Zotero.Prefs.get("zoteroocr.language");
// Convert existing instances with older or buggy defaults to English OCR
if (!ocrLanguage || ocrLanguage === 'undefined') {
ocrLanguage = 'eng';
Zotero.Prefs.set("zoteroocr.language", ocrLanguage);
}
parameters.push('-l');
parameters.push(ocrLanguage);

parameters.push('txt');
if (Zotero.Prefs.get("zoteroocr.outputPDF")) {
parameters.push('pdf');
Expand Down

0 comments on commit 1a34d94

Please sign in to comment.