Move plugin sources to subdirectory and remove trailing whitespace #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
This simplifies the build script. Signed-off-by: Stefan Weil <[email protected]>
|
That looks fine for me. Do you know whether we still need the |
|
Ah, I see it is still used because and hard-coded in the Line 16 in 12eaa79 Because this is already distributed among every active user of the plugin, I guess, we cannot change that easily. |
|
Yes, and update.rdf was also not part of the xpi file. The new src directory only contains files which should be included in the xpi file, so moving update.rdf to that directory would be wrong. |
Merged
|
Pull request #63 includes this pull request, so it can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.