Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issue regarding PS4 #17

Open
zundaxu opened this issue Feb 28, 2019 · 0 comments
Open

Some issue regarding PS4 #17

zundaxu opened this issue Feb 28, 2019 · 0 comments

Comments

@zundaxu
Copy link

zundaxu commented Feb 28, 2019

Hi all,

I have completed grading PS4. There is some issue about a common mistake I want to bring to your attention:

When calculating the estimated variance covariance matrix of the estimates, results.hess_inv is not a ndarray but a scipy.optimize.LbfgsInvHessProduct object, which will interpret '*' as dot multiplication instead of pointwise multiplication, thus generating irregular VCV result. Here we should use results.hess_inv.todense() * OffDiagNeg, i.e., transform it to a dense matrix, and then do the pointwise multiplication. @rickecon

Please don't hesitate to send me an email or come to my office hour if you have any question regarding your PS4's grades.

Best,
Winston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant