Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/app] Werkzeug 3.0.0 incompatible with flask-session 0.5.0 #972

Closed
nrybowski opened this issue Oct 10, 2023 · 0 comments · Fixed by #974
Closed

[frontend/app] Werkzeug 3.0.0 incompatible with flask-session 0.5.0 #972

nrybowski opened this issue Oct 10, 2023 · 0 comments · Fixed by #974
Labels

Comments

@nrybowski
Copy link
Member

Describe the bug

Accessing any page on the web frontend fails with a HTTP 500 error. See below for the server logs:

inginious-frontend-1      | Traceback (most recent call last):
inginious-frontend-1      |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 891, in finalize_request
inginious-frontend-1      |     response = self.process_response(response)
inginious-frontend-1      |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1270, in process_response
inginious-frontend-1      |     self.session_interface.save_session(self, ctx.session, response)
inginious-frontend-1      |   File "/inginious/inginious/frontend/flask/mongo_sessions.py", line 143, in save_session
inginious-frontend-1      |     response.set_cookie(self.get_cookie_name(app), session_id,
inginious-frontend-1      |   File "/usr/local/lib/python3.9/site-packages/werkzeug/sansio/response.py", line 224, in set_cookie
inginious-frontend-1      |     dump_cookie(
inginious-frontend-1      |   File "/usr/local/lib/python3.9/site-packages/werkzeug/http.py", line 1303, in dump_cookie
inginious-frontend-1      |     if not _cookie_no_quote_re.fullmatch(value):
inginious-frontend-1      | TypeError: cannot use a string pattern on a bytes-like object
inginious-frontend-1      | 
inginious-frontend-1      | 2023-10-10 18:44:04,470 - inginious.webapp.requests - INFO - 172.19.0.1:42332 - "- GET /signin" - 500 INTERNAL SERVER ERROR

INGInious installation details

To Reproduce
Steps to reproduce the behavior:

  1. Install INGInious on the provided hash.
  2. Launch INGInious services.
  3. Access to the web frontend.

Additional context
See pallets-eco/flask-session#191.

The version of the packages should be fixed and manually updated from release to release.
As discussed in #967, the CI should test for compatibility with new packages versions.

@nrybowski nrybowski added the Bug label Oct 10, 2023
nrybowski added a commit to nrybowski/INGInious that referenced this issue Oct 11, 2023
AlexandreDoneux pushed a commit to AlexandreDoneux/INGInious that referenced this issue Dec 7, 2023
jyounggo pushed a commit to jyounggo/INGInious that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant