Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Support UTF-8 #76

Open
ntlhui opened this issue Jul 25, 2023 · 0 comments
Open

FR: Support UTF-8 #76

ntlhui opened this issue Jul 25, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ntlhui
Copy link
Contributor

ntlhui commented Jul 25, 2023

e4e-data-management/e4e_data_management/metadata.py

Line 81 in e034866

with open(directory.joinpath('metadata.json'), 'r', encoding='ascii') as handle:

ascii encoding should be documented and some error handing might need to be here if user decides use characters in UTC-8, especially since there isn't anything blocking that input in the metadata class
@ntlhui ntlhui added enhancement New feature or request good first issue Good for newcomers labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntlhui