feat: Adds FSL requirements #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntlhui
requested review from
falafel72,
bmccalmon,
Kylehtran,
ccrutchf,
hnvultimate123,
avikg511 and
cyang406
ccrutchf
reviewed
Jan 27, 2025
| @@ -0,0 +1,9 @@ | |||
| # FishSense Lite System Requirements | |||
| - [ ] Maximum effective distance: 3 m | |||
| - [ ] Minimum effective distance: 0.5 m? (driven) | |||
There was a problem hiding this comment.
What does "driven" mean in this context?
There was a problem hiding this comment.
driven means that this is not a defining requirement, i.e. something else determines this requirement
| - [ ] Minimum effective distance: 0.5 m? (driven) | ||
| - [ ] Spatial resolution at max distance: < 1 mm | ||
| - [ ] Depth resolution at max distance: ??? (driven) | ||
| - [ ] Maximum length error of 5 cm object at max distance: < 5% |
There was a problem hiding this comment.
I'm not sure if this is the requirement for this device.
There was a problem hiding this comment.
What is the appropriate requirement for FSL?
| - [ ] Spatial resolution at max distance: < 1 mm | ||
| - [ ] Depth resolution at max distance: ??? (driven) | ||
| - [ ] Maximum length error of 5 cm object at max distance: < 5% | ||
| - [ ] On-board storage size: ??? |
There was a problem hiding this comment.
We should specify a total "charge time requirement" and define this based off of that.
There was a problem hiding this comment.
Please define a "charge time requirement"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.