Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled doxygen fail of warning #121

Closed
wants to merge 1 commit into from

Conversation

OliverWachtel
Copy link

Changed WARN_AS_ERROR from NO to FAIL_ON_WARNINGS_PRINT

@OliverWachtel OliverWachtel requested a review from ntlhui November 11, 2024 04:32
@OliverWachtel
Copy link
Author

Unsure about failed checks, could you help clarify?

@ntlhui ntlhui linked an issue Nov 12, 2024 that may be closed by this pull request
@ntlhui
Copy link
Contributor

ntlhui commented Nov 12, 2024

@OliverWachtel per the note in #103 , only do this when documentation build passes with no warnings. I am going to close this PR, since this is not ready to complete at this time (since there are still documentation build warnings). Please delete this branch.

@ntlhui ntlhui closed this Nov 12, 2024
@OliverWachtel OliverWachtel deleted the 103-re-enable-doxygen-fail branch November 12, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Re-enable doxygen fail on warning
2 participants