Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consolidate water sensor array length #122

Open
ntlhui opened this issue Nov 12, 2024 · 0 comments
Open

fix: Consolidate water sensor array length #122

ntlhui opened this issue Nov 12, 2024 · 0 comments
Assignees

Comments

@ntlhui
Copy link
Contributor

ntlhui commented Nov 12, 2024

Water sensor detect array length is provided both as a preprocessor define as well as runtime argument. Consolidate to preprocessor define only.

See

uint8_t water_detect_array[WATER_DETECT_ARRAY_SIZE];
,
moving_window_size(window_size)
,
for (uint8_t i = 0; (i < moving_window_size) && (i < samples_taken_since_reset); i++)
,
static WaterSensor waterSensor(WATER_DETECT_EN_PIN, WATER_DETECT_PIN, WATER_DETECT_SURF_SESSION_INIT_WINDOW);

@mariawaseem mariawaseem self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants