Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IMU get sensor readings return values #130

Open
ntlhui opened this issue Nov 14, 2024 · 1 comment · May be fixed by #165
Open

fix: IMU get sensor readings return values #130

ntlhui opened this issue Nov 14, 2024 · 1 comment · May be fixed by #165
Assignees
@atharvakedia

Comments

@ntlhui
Copy link
Contributor

ntlhui commented Nov 14, 2024

Functions have pointless return values. Resolve so that return values propagate failures.
@ntlhui
Copy link
Contributor Author

ntlhui commented Jan 6, 2025

smartfin-fw3/src/imu/imu.cpp

Line 48 in e104ce3

bool getAccelerometer(float *acc_x, float *acc_y, float *acc_z)

@atharvakedia atharvakedia linked a pull request Jan 13, 2025 that will close this issue
This PR fixes issue #130 by ensuring that IMU sensor functions return failure status correctly. #165
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atharvakedia atharvakedia

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ntlhui @atharvakedia