Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Data Upload #90

Open
6 tasks
ntlhui opened this issue Oct 1, 2024 · 2 comments · May be fixed by #132
Open
6 tasks

docs: Data Upload #90

ntlhui opened this issue Oct 1, 2024 · 2 comments · May be fixed by #132
Assignees

Comments

@ntlhui
Copy link
Contributor

ntlhui commented Oct 1, 2024

  • src/cellular/dataUpload.hpp:49: error: Member exitState(void) (function) of class DataUpload is not documented.
  • src/cellular/dataUpload.hpp:50: error: Member can_upload(void) (function) of class DataUpload is not documented.
  • src/cellular/dataUpload.hpp:47: error: Member initSuccess (variable) of class DataUpload is not documented.
  • src/cellular/dataUpload.hpp:48: error: Member lastConnectTime (variable) of class DataUpload is not documented.
  • <can_upload>:1: error: parameters of member DataUpload::can_upload are not documented
  • :1: error: parameters of member DataUpload::exitState are not documented

ed2263e

@Tylody Tylody self-assigned this Nov 15, 2024
@Tylody
Copy link
Contributor

Tylody commented Nov 15, 2024

Seems like DataUpload lastConnectTime (type of system_tick_t) has no uses outside of dataUpload.hpp. Should I remove it?

@Tylody Tylody linked a pull request Nov 15, 2024 that will close this issue
@ntlhui
Copy link
Contributor Author

ntlhui commented Nov 15, 2024

Seems like DataUpload lastConnectTime (type of system_tick_t) has no uses outside of dataUpload.hpp. Should I remove it?

lastConnectTime is likely a remnant or incomplete implementation of rate limiting calls to Particle.connect - previously, we could not do more than 1 call per second to Particle.connect. Leave this in place for now, we need to investigate whether the rate limiting is still a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants