Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30 system implement ride task #43

Open
wants to merge 281 commits into
base: main
Choose a base branch
from
Open

30 system implement ride task #43

wants to merge 281 commits into from

Conversation

charliekush
Copy link
Contributor

Finished scheduler and included tests in the tests directory.

@charliekush charliekush linked an issue May 14, 2024 that may be closed by this pull request
System: implement ride task #30
Open
@charliekush charliekush reopened this May 14, 2024
ntlhui
ntlhui requested changes May 21, 2024
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/c_cpp_properties.json Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/Doxyfile Outdated Show resolved Hide resolved
src/rideTask.hpp Outdated Show resolved Hide resolved
src/scheduler.cpp Outdated Show resolved Hide resolved
src/scheduler.cpp Outdated Show resolved Hide resolved
src/scheduler.cpp Outdated Show resolved Hide resolved
src/scheduler.cpp Outdated Show resolved Hide resolved
@ntlhui ntlhui force-pushed the 30-system-implement-ride-task branch from a50b38c to 856bb5a Compare May 23, 2024 20:10
@ntlhui
Copy link
Contributor

ntlhui commented May 24, 2024

Please remove meeting slides from this repo

charliekush added a commit that referenced this pull request May 29, 2024
@charliekush
fix: addressed issues with PR #43
ed4e634
@charliekush charliekush requested a review from ntlhui May 30, 2024 00:00
ntlhui
ntlhui requested changes Jun 5, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
.vscode/c_cpp_properties.json Outdated Show resolved Hide resolved
gtests/CMakeLists.txt Outdated Show resolved Hide resolved
gtests/CMakeLists.txt Outdated Show resolved Hide resolved
gtests/Makefile Outdated Show resolved Hide resolved
tests/scheduler_test_system.cpp Outdated Show resolved Hide resolved
tests/scheduler_test_system.cpp Outdated Show resolved Hide resolved
tests/scheduler_test_system.hpp Outdated Show resolved Hide resolved
tests/gtest.cpp Outdated Show resolved Hide resolved
tests/gtest.cpp Outdated Show resolved Hide resolved
@charliekush charliekush requested a review from ntlhui June 6, 2024 09:59
ntlhui
ntlhui requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ntlhui ntlhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all comments and requested changes

.vscode/launch.json Outdated
{
"type": "cppdbg",
"request": "launch",
"program": "${workspaceRoot}/tests/build/googletests.o",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not create executables with *.o extension - this is not convention

tests/gtest.cpp Outdated Show resolved Hide resolved
tests/scheduler_functions.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing all docstrings

tests/scheduler_test_system.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing all docstrings

tests/scheduler_test_system.hpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing all docstrings

ntlhui added 30 commits October 31, 2024 13:07
@ntlhui
docs: Fixes docstring
a6fd08b
@ntlhui
style: formats line
0524c96
@ntlhui
style: Organizes includes
02265c8
@ntlhui
docs: Cleans up docstrings
88a28e7
@ntlhui
style: Formats document
f5c802f
@ntlhui
docs: Adds docstrings
4b2f8d2
@ntlhui
chore: Adds doxygen runner options
2581eb0
@ntlhui
Merge branch '30-system-implement-ride-task' into integratingEnsembles
2cc173e
@ntlhui
Integrating ensembles (#54)
d1d58d0 
Ensembles taken from smartfin-v2, updated to work with scheduler and new
modules in smartfin-fw3
@ntlhui
chore: Removes extra whitespace
294203c
@ntlhui
style: Formats code
76e99b0
@ntlhui
style: Formats document
585f81a
@ntlhui
docs: Updates ride LED table
e2cc59c
@ntlhui
feat: Adds english output to FLOG dump
a3a5f7a
@ntlhui
style: Organizes includes
b33cbe9
@ntlhui
style: Formats state object table
864ff10
@ntlhui
docs: Updates docstrings
32c105e
@ntlhui
style: Formats document
c063faf
@ntlhui
feat: Merges flog and scheduler_test_flog
cf0bcb4
@ntlhui
fix: Fixes gcc FLOG display
ae897ef
@ntlhui
docs: Updates file docstring
3557682
@ntlhui
docs: Organizes includes
ccc9e99
@ntlhui
style: Formats document
c992495
@ntlhui
feat: Adds log formatter
af4a65f
@ntlhui
style: Fixes formatting and platform spec
6fd6047
@ntlhui
feat: Implemented ensemble hooks
c620a28
@ntlhui
feat: Adds state start flog formatter
e252dd4
@ntlhui
fix: Fixes task print format
a363b25
@ntlhui
fix: Adds src/states.cpp to compile list
c29055f
@ntlhui
Merge remote-tracking branch 'origin/main' into 30-system-implement-r…
0c9cc2d 
…ide-task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccrutchf ccrutchf ccrutchf left review comments

@ntlhui ntlhui Awaiting requested review from ntlhui

Requested changes must be addressed to merge this pull request.

Assignees

@ntlhui ntlhui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System: implement ride task
6 participants
@charliekush @ntlhui @ccrutchf @MAnn223 @antara-chugh @HannahCutler