Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into multiple files #4

Open
Eh2406 opened this issue Nov 9, 2016 · 1 comment
Open

Split into multiple files #4

Eh2406 opened this issue Nov 9, 2016 · 1 comment

Comments

@Eh2406
Copy link
Contributor

Eh2406 commented Nov 9, 2016

To start with this is my first time looking at the code, so take this as the first impression that it is. Does it make sense to split the project into multiple files? The ################### sections seam to build on each other. That may be a place to start the splitting.

As always just starting a discussion, and willing to help implement any fix.

@smmaurer
Copy link
Member

Yes, this might be a good idea. What are the pros and cons?

  • It would make the code more manageable
  • It would make it slightly more complicated for functions to call each other across the files
  • But it wouldn't have to affect the end-user API because we could just import all the individual files in __init__.py (?)

Other considerations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants