From d563ce73dc0f7ed4ee22f1569d1fc559ed57483b Mon Sep 17 00:00:00 2001 From: Hana Sevcikova Date: Tue, 2 May 2017 17:01:47 -0700 Subject: [PATCH] Fixed bug in developer.pick: compute max-profit over all forms if forms is None --- urbansim/developer/developer.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/urbansim/developer/developer.py b/urbansim/developer/developer.py index 95cd5b2f..3cf5e577 100644 --- a/urbansim/developer/developer.py +++ b/urbansim/developer/developer.py @@ -169,9 +169,7 @@ def pick(self, form, target_units, parcel_size, ave_unit_size, # no feasible buildings, might as well bail return - if form is None: - df = self.feasibility - elif isinstance(form, list): + if form is None or isinstance(form, list): df = self.keep_form_with_max_profit(form) else: df = self.feasibility[form]