Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/comment styling #53

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Feature/comment styling #53

merged 4 commits into from
Mar 2, 2021

Conversation

peytonjo
Copy link
Collaborator

@peytonjo peytonjo commented Mar 2, 2021

Description

  • Complete styling for view sighting page
  • Add title to each page view

Closes issue(s)

#49

Testing

Screenshots

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have written tests for this code (happy & sad)
  • I have updated the Readme
  • I ran full test suite - all tests passing
  • Lint code

Other comments

@peytonjo peytonjo requested review from mdflynn and jdxsmith March 2, 2021 21:34
@peytonjo peytonjo self-assigned this Mar 2, 2021
mdflynn
mdflynn approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@mdflynn mdflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling looks good

mdflynn
mdflynn previously requested changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@mdflynn mdflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct merge conflict locally

@mdflynn mdflynn merged commit 927f038 into main Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdflynn mdflynn mdflynn left review comments

@jdxsmith jdxsmith Awaiting requested review from jdxsmith

Assignees

@peytonjo peytonjo

Labels
Front-End styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peytonjo @mdflynn