Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require unit test for most basic spatial model #177

Open
stijnvanhoey opened this issue Oct 26, 2020 · 0 comments
Open

Require unit test for most basic spatial model #177

stijnvanhoey opened this issue Oct 26, 2020 · 0 comments

Comments

@stijnvanhoey
Copy link
Contributor

The adjustment of the spatial model, see 3a0909f#diff-58601479adea99fc373b6cfb66c6ee42a2f769b4a9b9f65f56b137eec146f2e0 is an important adjustment and extension to the model as it introduces the handling of multiple stratifications at the same time.

I do think this really needs unit testing (cfr. the simplified stratified version to test that part, https://github.com/UGentBiomath/COVID19-Model/blob/master/src/tests/test_model.py#L87-L105) in order to make sure we can further extend this.

@twallema, we can support you with setting up the etst but it would be good to have a kind of 'minimal' version of the SIRstratified -> SIRstratifiedSpatial to setup these tests.

As I understand it well, it will work as long as the stratification influences different parameters? If so, this should be clarified as well for other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant