Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder not working for pull requests from forks (parked for now) #55

Open
Beramos opened this issue May 28, 2020 · 3 comments
Open

Binder not working for pull requests from forks (parked for now) #55

Beramos opened this issue May 28, 2020 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Beramos
Copy link
Member

Beramos commented May 28, 2020

It seems that the GitHub workflow to generate binder links does not work for pull requests from forks. @stijnvanhoey, I originally thought this was not going to be a problem but now I realise that all changes will be coming from other forks. I'll check on this if I find some time next week

@Beramos Beramos added the bug Something isn't working label May 28, 2020
@stijnvanhoey
Copy link
Contributor

Indeed, good point. Moreover, the step of pip intall -e . should be included as well during setup to make sure the package/model itself is available inside the notebooks...

@stijnvanhoey
Copy link
Contributor

The latter issue on the pip install -e we can probably fix by adding a postBuild configuration file inside binder folder, see binder docs

@Beramos
Copy link
Member Author

Beramos commented May 29, 2020

I'm temporarily disabling the binder bot and moving the pip-install to a separate issue #59

@Beramos Beramos added the wontfix This will not be worked on label May 29, 2020
@Beramos Beramos changed the title Binder bot not working for pull requests from forks Binder not working for pull requests from forks (parked for now) May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants