Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package/model not available in binder #59

Closed
Beramos opened this issue May 29, 2020 · 3 comments
Closed

Package/model not available in binder #59

Beramos opened this issue May 29, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Beramos
Copy link
Member

Beramos commented May 29, 2020

As suggested in #55 by @stijnvanhoey

Indeed, good point. Moreover, the step of pip install -e. should be included as well during setup to make sure the package/model itself is available inside the notebooks.

The latter issue on the pip install -e we can probably fix by adding a postBuild configuration file inside binder folder, see binder docs

@jorisvandenbossche
Copy link
Contributor

If there is a setup.py, it should also install the package, according to https://mybinder.readthedocs.io/en/latest/config_files.html#setup-py-install-python-packages
Although I don't know if that works "additive" to environment.yml, or only one of both is used.

@Beramos
Copy link
Member Author

Beramos commented May 29, 2020

It is very cryptic

@Beramos Beramos added wontfix This will not be worked on and removed wontfix This will not be worked on labels May 29, 2020
@Beramos
Copy link
Member Author

Beramos commented May 30, 2020

The suggestion by @stijnvanhoey in #55 worked: adding a postBuild script to pip install the COVID model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants