Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calc_ratio] improve error message #280

Open
cdemulde opened this issue Jun 12, 2018 · 0 comments
Open

[calc_ratio] improve error message #280

cdemulde opened this issue Jun 12, 2018 · 0 comments
Assignees

Comments

@cdemulde
Copy link
Member

When setting the only_checked argument to True, but when one (or both) of the data series haven't been checked yet, this currently give a KeyError, which is confusing to the user, as (s)he doesn't know it concerns the self.meta_valid DataFrame, not the original DataFrame. Improve this to warn the user that only_checked cannot be fulfilled.
To be decided: proceed with calculation for all data points and just give a warning, or throw an error and stop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants