-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation/Schema does not indicate max lengths of properties #20
Comments
Our schema is using the JSON Schema standard, but so far as I can see that doesn't allow specification of max length or regex patterns. Can I ask whey they would be required? |
@timgent our QA is looking to gather test data which we will be using for unit tests within our application as well as Contract/E2E testing. We want to ensure we can handle responses from GRO gracefully. |
Ok. Turns out json schema does support all these things I just hadn't quite seen it, though regex patterns for strings seems maybe a bit much? We'd end up putting the entire character set in there to be allowed in any order! |
Will look to do a PR for this one too, but will wait for the others to be merged first |
That sounds great! I agree the regex for the whole character set is too much. |
It would be good if the schema in https://github.com/UKHomeOffice/lev-api-docs/blob/master/lev-api.md could indicate the
max length
/regex pattern
for string values on the response.The text was updated successfully, but these errors were encountered: