Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/Schema does not indicate max lengths of properties #20

Open
adamconder opened this issue Aug 18, 2016 · 5 comments
Open

Comments

@adamconder
Copy link

It would be good if the schema in https://github.com/UKHomeOffice/lev-api-docs/blob/master/lev-api.md could indicate the max length / regex pattern for string values on the response.

@timgent
Copy link
Contributor

timgent commented Aug 22, 2016

Our schema is using the JSON Schema standard, but so far as I can see that doesn't allow specification of max length or regex patterns. Can I ask whey they would be required?

@adamconder
Copy link
Author

@timgent our QA is looking to gather test data which we will be using for unit tests within our application as well as Contract/E2E testing. We want to ensure we can handle responses from GRO gracefully.

@timgent
Copy link
Contributor

timgent commented Aug 22, 2016

Ok. Turns out json schema does support all these things I just hadn't quite seen it, though regex patterns for strings seems maybe a bit much? We'd end up putting the entire character set in there to be allowed in any order!

@timgent
Copy link
Contributor

timgent commented Aug 22, 2016

Will look to do a PR for this one too, but will wait for the others to be merged first

@adamconder
Copy link
Author

That sounds great! I agree the regex for the whole character set is too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants