Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not show responses for invalid requests / error codes #26

Open
adamconder opened this issue Aug 23, 2016 · 2 comments

Comments

@adamconder
Copy link

adamconder commented Aug 23, 2016

Documentation should state the possible HTTP responses returned and their respective codes. If the body of the request contains an errors object with codes this should also be documented.
Examples of errors we've occurred so far:

  • Failed authentication (400 / 401)
  • Invalid headers (400)
  • Invalid endpoint (404)
  • TLS handshake failure - (403 / 500)
  • BadRequest (400)

It would be great if these were documented on the API and if possible descriptive error codes we're returned in the scenario of a BadRequest or Forbidden.

Based on the above are there other response codes being returned that we're unaware of?

@adamconder
Copy link
Author

@timgent I'd like to know if you's are looking into this as we're still receiving responses at times we don't expect. Sometimes get BadGateway back etc.
It would be good to clarify what responses you do return.

@timgent
Copy link
Contributor

timgent commented Sep 1, 2016

@adamconder Sorry for the delay on this, not a priority for us right now as got a few last minute panics before we spin up our production service.

As you say the following codes are currently encountered:
oauth/login endpoint:

  • 400 - wrong params
  • 418 - often caused if it is a post with no params
  • 401 - Expired token

Any endpoint:

  • 403 - no client certificate

Application endpoints

  • 404 - missing headers or no record

Interested if you are getting other errors. We haven't yet fixed our rolling update so when we deploy there is a little bit of downtime that could cause this. If you're getting issues outside of this though then it is something we should investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants