Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting array values in parameters (eg. ip_addresses, dns_names) #41

Open
munnerz opened this issue Jun 15, 2017 · 0 comments
Open

Setting array values in parameters (eg. ip_addresses, dns_names) #41

munnerz opened this issue Jun 15, 2017 · 0 comments

Comments

@munnerz
Copy link
Contributor

munnerz commented Jun 15, 2017

After looking through the codebase for vault-sidekick, it appears values that are passed in the cn are set as the JSON request body to Vault. With the current way this is done (here https://github.com/UKHomeOffice/vault-sidekick/blob/master/vault_resources.go#L135 and https://github.com/UKHomeOffice/vault-sidekick/blob/master/vault.go#L322), I'm unsure if it's possible to pass any values that should be arrays?

Specifically I'm using the PKI backend and want to add a list of IP addresses and DNS names that should be present on the certificate.

Have you got any example of how to do this with vault-sidekick? Or otherwise, how you'd like to see this implemented? Comma-separated may work, but it'd require specifically hard-coding data structures that vault accepts into vault-sidekick (so that we could detect if something should or shouldn't be a list). Alternatively we could use a syntax closer to JSON, eg. ip_addresses=['ip-1'] etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant