Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hof-logger rather than bespoke implementation #32

Open
joefitter opened this issue Jul 20, 2016 · 7 comments
Open

use hof-logger rather than bespoke implementation #32

joefitter opened this issue Jul 20, 2016 · 7 comments

Comments

@joefitter
Copy link
Contributor

lib/logger should be removed and replaced with hof-logger.

hof-logger allows defaults to be overridden so should we build this into the bootstrap options? Alternative is to be opinionated and use sensible defaults as per GRO, ROTM and BRP

@JoeChapman
Copy link
Contributor

@joefitter hmm are there many options that can be overridden for logger?

@JoeChapman
Copy link
Contributor

@joefitter has this been done?

@joefitter
Copy link
Contributor Author

No, still to-do

@JoeChapman
Copy link
Contributor

@joefitter can whoever does this please add an instance of the logger to the request object so it can be accessed by the controllers and middleware of any service that is using bootstrap?

@joefitter
Copy link
Contributor Author

@easternbloc didn't you do this in churchill?

@easternbloc
Copy link
Contributor

@joefitter I started then got distracted

@easternbloc
Copy link
Contributor

@joefitter oh look a 🐝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants