Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output from SUEWS #2

Closed
biglimp opened this issue Feb 15, 2021 · 3 comments
Closed

Output from SUEWS #2

biglimp opened this issue Feb 15, 2021 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@biglimp
Copy link
Contributor

biglimp commented Feb 15, 2021

Are these files still valid? I am moving SUEWSAnalyzer over to the UMEP for Processing and I see that these are hard coded.
SUEWS_OutputFormatOption1.txt
SUEWS_OutputFormatOption2.txt

@biglimp biglimp added the question Further information is requested label Feb 15, 2021
@sunt05
Copy link
Contributor

sunt05 commented Feb 18, 2021

Yes, they are.
But as we are using SuPy inside UMEP, I'm wondering if these are still needed and how we may better deal with these.

Can you point me to the code where these files are actually used?

@biglimp
Copy link
Contributor Author

biglimp commented Feb 18, 2021

They are used to prepare the Plugin-interface in SUEWSAnalyzer on which parameters that are available for post-processing and what their units are. https://github.com/UMEP-dev/UMEP/blob/52a0f7ff9c1ac4cc92b48ee14013e8e0c1d9733d/SUEWSAnalyzer/suews_analyzer.py#L290

@sunt05
Copy link
Contributor

sunt05 commented Feb 18, 2021

double-checked these files are still valid; but I'm thinking we may use python pickled files for easier post-processing, which can also naturally integrate support for units (thanks to pandas-pint).
Let me think how we can more elegantly deal with this.

related: UMEP-dev/SUEWS#158

@biglimp biglimp closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants