Feature/plotly theming #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 15, 2024
mykolaskrynnyk
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Let's keep the package scoped to Streamlit with plotly theming being a small extra, rather than trying to provide plotting-like functionality. We also don't need to store large dictionaries, these can go to data folder as JSONs. Some code parts can be significantly improved. See the comments elsewhere.
There was a problem hiding this comment.
This is overly verbose. Some of the keys in undp_colors are used only once (or not at all).
- Write the configuration explicitly in the dictionary inside
custom_template.layout.update(even if this requires repetition). - Remove
undp_colours. - Move the template dictionary to
data/as a JSON file, them read it back here withutils.read_file. - Call the template
"undp"instead of"undp_template".
There was a problem hiding this comment.
I removed undp_colors from plotly_themes and placed it in data/ for reference although it is currently not used.
…wcase concrete examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This request mainly adds theming functionality for Plotly charts by adding a custom theme to Plotly and a prebuilt wrapper for a few plot types. A new integration page is also introduced to the demo application to showcase the new Plotly theme feature.
Furthermore, this request addresses the link animation on-hover effect (#4), visited URL style, and checkbox state issue (#5 (comment)).
New Features
standardpageBug Fixes
Checklist
pyproject.tomland updatedpoetry.lock(if applicable).Screenshots / Examples
Additional Notes
None