Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect stack identification #100

Closed
ailrst opened this issue Oct 13, 2023 · 3 comments · Fixed by #102
Closed

Incorrect stack identification #100

ailrst opened this issue Oct 13, 2023 · 3 comments · Fixed by #102

Comments

@ailrst
Copy link
Contributor

ailrst commented Oct 13, 2023

The tool can output stores to mem at addresses that are explicitly offsets from the stack pointer such as here
#99

This may be improved by implementing stack identification based on the memory region analysis, or fixed in the prototype implementation of stack identification first.

@l-kent
Copy link
Contributor

l-kent commented Oct 13, 2023

Can you give a proper example of this? I don't know where your example in #99 came from

@ailrst
Copy link
Contributor Author

ailrst commented Oct 13, 2023

This is the same example; https://gist.github.com/ailrst/60133afbeda1aab9255752adee510553#file-example-bpl-L354

Or do you want me to find an instance in an existing example?

@l-kent
Copy link
Contributor

l-kent commented Oct 13, 2023

That's fine, thanks.

l-kent pushed a commit that referenced this issue Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants