Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure summaries involving global variables when memory is not accessed #236

Open
l-kent opened this issue Aug 22, 2024 · 0 comments
Open

Comments

@l-kent
Copy link
Contributor

l-kent commented Aug 22, 2024

The procedure summarisation currently in some cases produces summaries relating to global variables even when a procedure does not access memory at all. An example of this is the procedure_summary test in ProcedureSummaryTests, which generates summaries for the global variables x and y for the procedure get_two, even though that procedure doesn't access memory at all. These summaries are redundant.

According to @b-paul this is because global variables are initially marked as tainting themselves in a procedure, even if memory is never accessed, leading to them erroneously being used in the procedure summary. It should be checked whether memory is accessed at all (or the relevant memory region for a global variable, once that is added), before generating summaries for global variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant