Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfg Construction for Jumps #97

Closed
l-kent opened this issue Oct 12, 2023 · 0 comments · Fixed by #140
Closed

Cfg Construction for Jumps #97

l-kent opened this issue Oct 12, 2023 · 0 comments · Fixed by #140

Comments

@l-kent
Copy link
Contributor

l-kent commented Oct 12, 2023

visitJumps in the `ProgramCfgFactory' needs to be rewritten as it contains multiple incorrect assumptions about the IR, such as that there are a maximum of two jumps per block, and GoTos can only follow GoTo. These may hold for the input we get from BAP but are not guaranteed to hold if we transform the program representation further (such as by resolving an indirect call to multiple direct calls) and then reconstruct the IR afterwards. A new approach should create the Cfg from the IR as it is presented, without making assumptions.

@l-kent l-kent linked a pull request Nov 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant