add example with quantified specs #99
Merged
+1,530
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the .adt, .bir and .relf files for this example. I'll merge this, but the specification won't work until you merge in #93 which this relies on. Which stack regions are misidentified at present? Please submit an issue for that. |
Should this load be from stack since its an offset from SP? |
|
Minor note but it's .bir not .bil. BIL is a different output from BAP. That does look like it should be a load from stack, but please make an issue for it. |
Ah, sorry I remembered your comment on the other pr but couldn't remember which one was correct :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example we tried to put together for the demo, with some notes on what was necessary to get the quantification specs to work.
This example isn't working well enough to become a test case or anything since the tool currently mis-identifies some stack regions as mem, but I want to keep the notes around.