fix important warnings

UQ-PAC · Apr 5, 2024 · 5b2b66a · 5b2b66a
1 parent 23947c3
commit 5b2b66a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/offlineASL-cpp/subprojects/aslp-lifter/dummy.cpp b/offlineASL-cpp/subprojects/aslp-lifter/dummy.cpp
diff --git a/offlineASL-cpp/subprojects/aslp-lifter/include/aslp/interface.hpp b/offlineASL-cpp/subprojects/aslp-lifter/include/aslp/interface.hpp
@@ -14,7 +14,7 @@ concept lifter_traits = requires(T)
     typename T::rt_label;
 };
 
-template <lifter_traits Traits>
+template <typename Traits>
 class lifter_interface : public Traits {
 public:
   // bits which are known at lift-time
@@ -31,6 +31,7 @@ class lifter_interface : public Traits {
   // TODO: split lift-time interface from run-time interface
   // TODO: more flexible method of adding const-lvalue qualifiers
 public:
+  virtual ~lifter_interface() = default;
 
   virtual rt_lexpr v_PSTATE_C() = 0;
   virtual rt_lexpr v_PSTATE_Z() = 0;

diff --git a/offlineASL-cpp/subprojects/aslp-lifter/meson.build b/offlineASL-cpp/subprojects/aslp-lifter/meson.build
@@ -18,6 +18,9 @@ instantiate_dep = declare_dependency(
   dependencies: gen_dep,
   compile_args: ['-Wno-unused-parameter'])
 
+# needed to generate compile_commands.json when building this subproject standalone
+dummy_lib = library('dummy', 'dummy.cpp', dependencies: gen_dep, install: false)
+
 pkg = import('pkgconfig')
 pkg.generate(
   name: meson.project_name(),