Rework Memory Prims #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Memory.[set,read] to represent primitive memory operations - Override Mem.[set,read] to include desired atomicity behaviour & call new memory prims - Begin moving arch specific details into a centralised config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We replace existing memory primitives,
Mem.readandMem.set, with new primitivesMemory.readandMemory.set. These new primitives decouple the generated ASL from the architecture specification, allowing us to configure the memory model precision viatests/override.asl. This is motivated by #49, which we resolve by inlining the existing (overridden) primitives to capture the semantics of 128-bit operations.The new primitives are identical to the existing, with the only difference being a change in the function name. Consequently, this will require a minor modification to any downstream projects.