Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Updated comments"" #49

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

The-AhmadAA
Copy link
Contributor

Reverts #46 - The previous revert deleted a large chunk of the Team 2 feature files. This revert restores the deleted files and the tower functionality and assets. This functionality is what was intended to be merged in PR #48
To the reviewers - Please give this some attention as I don't want to cause any more inadvertent issues.

@The-AhmadAA The-AhmadAA added help wanted Extra attention is needed team 2 sprint 1 labels Aug 25, 2023
@The-AhmadAA The-AhmadAA added this to the Sprint 1 milestone Aug 25, 2023
Copy link
Contributor

@MiniSoda17 MiniSoda17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry about the previous approval, didn't realise to question all the removal of code. But it looks like code has actually been added this time.

Copy link
Contributor

@freshc0w freshc0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Want to add that maybe add optional parameters when spawning the towers that can be set at specified locations instead of only relying on a default value. I understand tho that for now, the spawn locations are random and only for testing purposes.

@The-AhmadAA The-AhmadAA merged commit 92b50e6 into main Aug 26, 2023
@The-AhmadAA The-AhmadAA deleted the revert-46-revert-45-Tower-Graphics branch August 29, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed sprint 1 team 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants