Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate file for the #FORM blocks #26

Open
krowvin opened this issue May 15, 2024 · 1 comment
Open

Separate file for the #FORM blocks #26

krowvin opened this issue May 15, 2024 · 1 comment

Comments

@krowvin
Copy link
Collaborator

krowvin commented May 15, 2024

Consider adding the ability to also load a file in.

If you have HTML in your #FORM content, for example, this will break:

  • Syntax highlighting for that given file type (i.e. CSV/HTML/etc)
  • Linting for HTML, CSS, JavaScript if it is HTML
  • Autoformatting based on filetype

Consider making this backwards compatible. Perhaps have the form builder check if #FORM is present and if not run the file normally. Then provide a class/constructor for reading template files that load them in as is.

Could use a template engine like handlebars but would probably be fine keeping it as is so we do not have to convert reports. People can just chose if they want to strip that current #FORM content into another file.

@krowvin
Copy link
Collaborator Author

krowvin commented May 16, 2024

@DanielTOsborne do you have a means of testing this or will the automated checks be enough for this?

I tested against our current report for both #FORM and #FORMFILE

Edit: I created #28 for automated testing for data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant