Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Minimum/maximum cord display and error message change: As a permit purchaser, I need to have the minim and maximum number for cords I'm allowed to purchase clearly displayed so that I know my limitations before beginning the purchasing process. #209

Open
7 of 9 tasks
Dmac26 opened this issue Oct 19, 2020 · 5 comments
Assignees
Labels
Engineering enhancement New feature or request

Comments

@Dmac26
Copy link

Dmac26 commented Oct 19, 2020

Background
Users should see a message on the "buy a permit" page that informs them of the range of cords they are allowed to purchase. Additionally, if the use inputs a cord amount that is above or below the set range, they should see an error message that properly informs them of the violation.

Below is an example of the desired language per @jstrothman

image.png

Acceptance criteria

  • Users can see a hint message that clearly delineates the range of cord amounts they are allowed to purchase
  • Users need to see an error message that clearly informs them of the proper range if they have violated it with their input

Tasks

  • Update hint language to match the requested change
  • Update the error message to match the requested change
  • Validation of acceptance criteria completed
  • Code review
  • Design review
  • PO Approved

Definition of done

  • Pull requests meet technical definition of done.
@Dmac26 Dmac26 added Engineering enhancement New feature or request labels Oct 19, 2020
@Dmac26 Dmac26 self-assigned this Oct 19, 2020
@Dmac26 Dmac26 changed the title Minimum/maximum cord display and error message change: As a permit purchaser, I need to have the minim and maximum number for cords I'm allowed to purchase clearly displayed so that I now my limitations before beginning the purchasing process. Minimum/maximum cord display and error message change: As a permit purchaser, I need to have the minim and maximum number for cords I'm allowed to purchase clearly displayed so that I know my limitations before beginning the purchasing process. Oct 19, 2020
@Dmac26
Copy link
Author

Dmac26 commented Oct 19, 2020

@MelissaBraxton and @jstrothman - I just wanted to give both of you an update before I head out for the day. I completed the language updates you requested and opened a Pull Request on this issue. It was pretty straightforward so I imagine I should be able to push this up tomorrow morning once one of the other Devs give the PR a thumbs up.

I'm posting the PR below here:

USDAForestService/fs-open-forest-platform#1493

@Dmac26
Copy link
Author

Dmac26 commented Oct 20, 2020

@MelissaBraxton and @jstrothman - Alrighty, this has now been merged up to the dev branch. It should be viewable within the next 20-30 min (current time: 9:00AM CST).

@Dmac26 Dmac26 assigned jstrothman and Dmac26 and unassigned Dmac26 and jstrothman Oct 20, 2020
@jstrothman
Copy link
Collaborator

Looks great. Thank you @Dmac26

@jstrothman jstrothman assigned bboddiger and Dmac26 and unassigned jstrothman and bboddiger Oct 20, 2020
@jstrothman
Copy link
Collaborator

@Dmac26 Once this is on staging, could you move it to Awaiting Acceptance and assign it to @bboddiger ?

@Dmac26
Copy link
Author

Dmac26 commented Oct 21, 2020

@jstrothman - Will do! Thanks for taking a look at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Engineering enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants