Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General enhancements for standardization #180

Open
knoiva-indecon opened this issue Jul 10, 2024 · 1 comment
Open

General enhancements for standardization #180

knoiva-indecon opened this issue Jul 10, 2024 · 1 comment

Comments

@knoiva-indecon
Copy link
Collaborator

General enhancements for standardization and efficiency (will require coordination with FrEDI Data), in order of staging:

  1. ImpactYear label. Change "NA" label in impactYear column of run_fredi outputs to "N/A" instead of "NA" (use label instead of id) for consistency. All results will be different if impactYear is not included in aggLevels argument.
  2. Scenarios. Add steps to "Build FrEDI" workflow to update scenarios in "data" and "inst/extdata/scenario" directories of FrEDI package. Also include the GDP scenario (see Issue Default scenarios #85)
  3. Remove "byState" arguments and steps throughout run_fredi and helper functions. Can still use popCols = c("state", "postal"). Change the name of the population column from state_pop to just pop.

May add additional standardizations to come.

@knoiva-indecon knoiva-indecon changed the title General enhancements for standardizations General enhancements for standardization Jul 10, 2024
@knoiva-indecon
Copy link
Collaborator Author

knoiva-indecon commented Nov 25, 2024

This issue is addressed in the fredi_methane_reorg branch, and will be merged into main with pull request #201. It can be closed after merging into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant