New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_ng_transmission_import_proxy.py #55

Open

burnettear opened this issue Jan 27, 2025 · 3 comments

Assignees

Collaborator

burnettear commented Jan 27, 2025

Code review of file task_ng_transmission_import_proxy.py

Good:

Well documented
Header added to be compliant
Function docstring added

Improvements:

Header added to be compliant
Code chunk structure adjusted for readability
Global_data_dir_path import removed, unused

TODO:

@haclohman See TODO comments here in the code review branch.
Review script and approve changes/follow-up

burnettear assigned haclohman

Collaborator Author

burnettear commented Jan 27, 2025

Check Header and docstring purpose to ensure it's accurate. I based the purpose on the AI recommendations from John B's code review directory.

Collaborator Author

burnettear commented Jan 27, 2025

Changed to @Jbollenbacher

burnettear assigned Jbollenbacher and unassigned haclohman

Collaborator Author

burnettear commented Jan 27, 2025

https://github.com/USEPA/GEPA/blob/code_review_2024-12/gch4i/proxy_processing/task_ng_transmission_import_proxy.py

Corrected link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment