Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split visualize.storm into subfunctions #4

Open
aappling-usgs opened this issue Oct 2, 2017 · 5 comments
Open

Split visualize.storm into subfunctions #4

aappling-usgs opened this issue Oct 2, 2017 · 5 comments

Comments

@aappling-usgs
Copy link
Member

(where visualize.storm starts as something like https://github.com/USGS-VIZLAB/hurricane-irma/blob/master/scripts/visualize/visualize.hurricane_map.R)

Decompose visualize.storm into more subfunctions for things like base map with info, gage points, sparklines, legend, watermark

@aappling-usgs
Copy link
Member Author

What's the difference between the svg_base_map and hurricane_map? It's not that one is static while the other is animated...links to #10

@jordansread
Copy link

I think the idea with base_map is it is used to get all of the geometries into the svg in the right place and with the right ids

The second function was used to add sparklines, legend, and in some cases, copy elements and make them transparent (so that their mouse events are on "top" but their visual appears below)

@aappling-usgs
Copy link
Member Author

Which things count as geometries? I ask because sparklines and legend circles and even legend text sound to me like they could be geometries.

@jordansread
Copy link

I would agree with that. There is a potential divider between geo (map) elements that are placed according to their coordinates and the projection, and then other geometries that are created and placed according to the svg bounds (such as, place this watermark 10px from the upper right). I think legends and sparks fall into the latter category.

@aappling-usgs
Copy link
Member Author

OK, thanks. I agree that it makes sense to pick some rule for dividing the functions, and geographic elements vs annotation elements seems sensible, too. Let's just get some more text about that into comments as we harden this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants