-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split visualize.storm into subfunctions #4
Comments
What's the difference between the svg_base_map and hurricane_map? It's not that one is static while the other is animated...links to #10 |
I think the idea with The second function was used to add sparklines, legend, and in some cases, copy elements and make them transparent (so that their mouse events are on "top" but their visual appears below) |
Which things count as geometries? I ask because sparklines and legend circles and even legend text sound to me like they could be geometries. |
I would agree with that. There is a potential divider between geo (map) elements that are placed according to their coordinates and the projection, and then other geometries that are created and placed according to the svg bounds (such as, place this watermark 10px from the upper right). I think legends and sparks fall into the latter category. |
OK, thanks. I agree that it makes sense to pick some rule for dividing the functions, and geographic elements vs annotation elements seems sensible, too. Let's just get some more text about that into comments as we harden this. |
(where visualize.storm starts as something like https://github.com/USGS-VIZLAB/hurricane-irma/blob/master/scripts/visualize/visualize.hurricane_map.R)
Decompose visualize.storm into more subfunctions for things like base map with info, gage points, sparklines, legend, watermark
The text was updated successfully, but these errors were encountered: