Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use arbitrary Ansatzes to calculateP #139

Open
lcgraham opened this issue Jul 16, 2015 · 4 comments
Open

Add the ability to use arbitrary Ansatzes to calculateP #139

lcgraham opened this issue Jul 16, 2015 · 4 comments

Comments

@lcgraham
Copy link
Contributor

No description provided.

@mpilosov
Copy link
Contributor

Just to clarify, is this still true or does the sample object's probabilities attribute take care of this?
From my glance at calculateP (very early stages of learning to read code written in parallel), it seems like this is no longer an issue.

@lcgraham
Copy link
Contributor Author

lcgraham commented Jun 23, 2016

This is still true. The standard ansatz is used in all of the prob methods in bet.calculateP.calculateP as the line:

P[Itemp] = discretization._output_probability_set._probabilities[i]/Itemp_sum

and :

P_local[Itemp] = discretization._output_probability_set._probabilities[i]*discretization._input_sample_set._volumes_local[Itemp]/Itemp_sum``

@lcgraham
Copy link
Contributor Author

I think this could be done by using the emulated input sample set appropriately.

@mathematicalmichael
Copy link
Collaborator

I actually accomplished this by setting probabilities to 1/num_samples if empty, and then using that vector in place of volumes in the main loop of calcP.prob.

@lcgraham This feature is coming down the line very soon, I think I can make it it's own PR. It will be aligned with setting an "initial" distribution which we "update". If unspecified, uniform is assumed.

Check out the animation in #161 to see it in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants