Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Touch ups for Semester Filter #249

Closed
8 of 9 tasks
AbhiramTadepalli opened this issue Oct 8, 2024 · 7 comments · Fixed by #322
Closed
8 of 9 tasks

[Feature Request] Touch ups for Semester Filter #249

AbhiramTadepalli opened this issue Oct 8, 2024 · 7 comments · Fixed by #322
Assignees
Labels
Type: Feature Request New feature or request

Comments

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Oct 8, 2024

Overview

#240 added the Semester filter, but it's full functionality / UI is incomplete

Proposal

Touch ups for Semester Filter

Supplementary Information

@sparklingwter
Copy link
Contributor

hi, i thought this update was done for a bit with my update? if not, i can take still take care of it

@sparklingwter
Copy link
Contributor

@AbhiramTadepalli please do not work on this because i will run out of issues if you do. Focus on your Mobile UI tyvm - ANNIE

@AbhiramTadepalli
Copy link
Contributor Author

image
Does this look too crowded?

@AbhiramTadepalli
Copy link
Contributor Author

@TyHil can you help me get select all to have the bg color when it is fully checked?

@TyHil
Copy link
Member

TyHil commented Nov 5, 2024

Looks like you might be able to manually apply the .Mui-selected class when the "select all" or "recent" checkboxes are checked

@AbhiramTadepalli
Copy link
Contributor Author

In the latest commit 3b60832 I tried to center the text to the checkbox vertically but it didn't seem to work. Any ideas?

@TyHil
Copy link
Member

TyHil commented Nov 5, 2024

The text is further embedded in a div and not centered in that, not sure what you can do
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants