Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMTRAN vs NM-TRAN #200

Open
rfaelens opened this issue Mar 17, 2022 · 2 comments
Open

NMTRAN vs NM-TRAN #200

rfaelens opened this issue Mar 17, 2022 · 2 comments

Comments

@rfaelens
Copy link

In

if (any(stringr::str_detect(model$code, 'NM-TRAN MESSAGES'))) {
, the code searches for the magic string NM-TRAN MESSAGES.

Some software uses NMTRAN MESSAGES instead (note absence of the hyphen).

The package would be much more flexible if all magic strings can be put into an option. That way, I could simply execute
options(xpose.magic.nmtranMessages = "NMTRAN MESSAGES"), instead of adapting the LST file manually or adapting the xpose code.

@bguiastr
Copy link
Collaborator

Thanks for the input @rfaelens. Do you expect many more variations of NMTRAN vs NM-TRAN? If not I would simply add the hyphen as optional in the regular expression.

@rfaelens
Copy link
Author

I do not expect any other variations; what you propose would also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants